-
Notifications
You must be signed in to change notification settings - Fork 1k
Dark Mode issues Fixes #13474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Dark Mode issues Fixes #13474
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13474 +/- ##
===================================================
+ Coverage 76.59823% 76.59997% +0.00173%
===================================================
Files 3230 3230
Lines 639097 639153 +56
Branches 47289 47297 +8
===================================================
+ Hits 489537 489591 +54
+ Misses 145992 145984 -8
- Partials 3568 3578 +10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Hey @memoarfaa, thanks for this PR, but let's try to coordinate the efforts here, so we're not doing redundant work. We'll be addressing for Preview 5 (maybe early 6) the PRs which I did, since they had been planned and championed. We only have Monday 19th to complete testing, reviews and merge them, so the Preview 5 ship for any pivoting in approaches has sailed. For Preview 6, I'd love to re-discuss approaches, though, so, let's keep the discussion rolling for improvements for the Preview 6 time frame! PS: |
Ok I will do
I understand that for Preview 5, only the already planned/championed PRs can be considered, and my changes won’t be merged at this stage.
For Preview 6, I’m happy to continue iterating on these improvements and would appreciate any feedback or direction from the team on priorities or preferred approaches.
About Read-Only TextBox Background Coloring in Dark Mode I don't understand what you mean by
If you mean the Win32 default theme Color the answer is no because it handled by WM_CTLCOLOR XXXX
in RichTextBox Class
Recording.2025-05-19.095641.mp4 |
Fix Dark Mode issues
Fixes #12027
Fixes #12992
Fixes #12991
Fixes #12582
Fixes #11941
Fixes #11932
Microsoft Reviewers: Open in CodeFlow